Re: [PATCH RFC 3/7] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller

Tommaso Merciai
2025-07-02T22:06:57Z

Hi Wolfram, Rob,

On 30/06/25 21:43, Wolfram Sang wrote:
>
>>> + interrupt-names:
>>> + items:
>>> + - const: ierr
>>> + - const: terr
>>> + - const: abort
>>> + - const: resp
>>> + - const: cmd
>>> + - const: ibi
>>> + - const: rx
>>> + - const: tx
>>> + - const: rcv
>>> + - const: st
>>> + - const: sp
>>> + - const: tend
>>> + - const: nack
>>> + - const: al
>>> + - const: tmo
>>> + - const: wu
>>> + - const: exit
>>> + minItems: 16
>>> +
>>> + clocks:
>>> + oneOf:
>>> + - items:
>>> + - description: APB bus clock
>>> + - description: transfer clock
>>> + - items:
>>> + - description: APB bus clock
>>> + - description: SFRs clock
>>> + - description: transfer clock
>>
>> It's a new binding, why don't you put SFRs clock last and simplify the
>> schema?
>
> Similar how we handle interrupts? 16 for the one SoC, 17 for the other?
> Putting the optional entry to the end of the array? Tommaso, can you
> integrate this change, please?
>

clocks:
items:
- description: APB bus clock
- description: transfer clock
- description: SFRs clock
minItems: 2

clock-names:
items:
- const: pclk
- const: tclk
- const: pclkrw
minItems: 2

...

allOf:
- $ref: i3c.yaml#

- if:
properties:
compatible:
contains:
const: renesas,r9a08g045-i3c
then:
properties:
clocks:
maxItems: 2
clock-names:
maxItems: 2
interrupts:
minItems: 17
interrupt-names:
minItems: 17

- if:
properties:
compatible:
contains:
const: renesas,r9a09g047-i3c
then:
properties:
clocks:
minItems: 3
clock-names:
minItems: 3
interrupts:
maxItems: 16
interrupt-names:
maxItems: 16

Right?
Please correct me if I'm missing somenthing.
Thanks in advance.

Thanks & Regards,
Tommaso