[PATCH] i3c: add missing include to internal header

[PATCH] i3c: add missing include to internal header

[Wolfram Sang]

LKP found a random config which failed to build because IO accessors
were not defined:

   In file included from drivers/i3c/master.c:21:
   drivers/i3c/internals.h: In function 'i3c_writel_fifo':
>> drivers/i3c/internals.h:35:9: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]

Add the proper header to where the IO accessors are used.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507150208.BZDzzJ5E-lkp@intel.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i3c/internals.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h
index 67ed1c44f615..1bf6aecebcbb 100644
--- a/drivers/i3c/internals.h
+++ b/drivers/i3c/internals.h
@@ -9,6 +9,7 @@
 #define I3C_INTERNALS_H
 
 #include <linux/i3c/master.h>
+#include <linux/io.h>
 
 extern const struct device_type i3c_masterdev_type;
 
-- 
2.47.2


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH] i3c: add missing include to internal header

[Wolfram Sang]

On Thu, Jul 17, 2025 at 02:00:47PM +0200, Wolfram Sang wrote:
> LKP found a random config which failed to build because IO accessors
> were not defined:
> 
>    In file included from drivers/i3c/master.c:21:
>    drivers/i3c/internals.h: In function 'i3c_writel_fifo':
> >> drivers/i3c/internals.h:35:9: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]
> 
> Add the proper header to where the IO accessors are used.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507150208.BZDzzJ5E-lkp@intel.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Fixes: b7371ff9bdf7 ("i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()")


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

Re: [PATCH] i3c: add missing include to internal header

[Frank Li]

On Thu, Jul 17, 2025 at 02:00:47PM +0200, Wolfram Sang wrote:
> LKP found a random config which failed to build because IO accessors
> were not defined:
>
>    In file included from drivers/i3c/master.c:21:
>    drivers/i3c/internals.h: In function 'i3c_writel_fifo':
> >> drivers/i3c/internals.h:35:9: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]
>
> Add the proper header to where the IO accessors are used.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507150208.BZDzzJ5E-lkp@intel.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/i3c/internals.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h
> index 67ed1c44f615..1bf6aecebcbb 100644
> --- a/drivers/i3c/internals.h
> +++ b/drivers/i3c/internals.h
> @@ -9,6 +9,7 @@
>  #define I3C_INTERNALS_H
>
>  #include <linux/i3c/master.h>
> +#include <linux/io.h>
>
>  extern const struct device_type i3c_masterdev_type;
>
> --
> 2.47.2
>

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c