From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Durai.ManickamKR@microchip.com
Cc: linux-i3c@lists.infradead.org, alexandre.belloni@bootlin.com,
Hari.PrasathGE@microchip.com
Subject: Re: [RFC] SAMA7D65 SoC I3C controller driver
Date: Wed, 30 Jul 2025 13:41:41 +0200 [thread overview]
Message-ID: <aIoE9ejPYwzswk2B@shikoro> (raw)
In-Reply-To: <cbe773d1-f056-49b1-8c64-eea57ca8a9ea@microchip.com>
Hi,
> So my query here are,
>
> 1.
> Whether this approach is correct or not.
> 2.
> Instead of creating a new driver file, shall we introduce a quirck
> for Microchip I3C and integrate the changes in the existing driver.
It depends, I would say. I would start with approach 2), but maybe not
call it 'quirks' but 'config'. If the code stays readable while working
on that, it probably is worth it to follow that road. If you are adding
so much code handling the differences that the result is hardly readable
anymore, then approach 1) might be the better one in the end. I don't
know your hardware, so I can't guess. But you might already have a gut
feeling which is better.
This is how it is handled in most subsystems I work with. Note that
Frank and Alexandre have the ultimate call here.
Happy hacking,
Wolfram
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-07-30 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 10:55 [RFC] SAMA7D65 SoC I3C controller driver Durai.ManickamKR
2025-07-30 11:41 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-30 10:14 Durai.ManickamKR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIoE9ejPYwzswk2B@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Durai.ManickamKR@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).