From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>,
linux-i3c@lists.infradead.org
Subject: Re: [PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa'
Date: Mon, 4 Aug 2025 10:57:55 +0200 [thread overview]
Message-ID: <aJB2E5wJ0gtIOy0f@tom-desktop> (raw)
In-Reply-To: <20250803211256.18513-2-wsa+renesas@sang-engineering.com>
Hi Wolfram,
Thanks for your patch!
On Sun, Aug 03, 2025 at 11:12:57PM +0200, Wolfram Sang wrote:
> There was already a bail out for 'ret < 0', so we can always return
> success at the end of the function.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/aIyzJ7HOENL1qp1l@stanley.mountain
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
> drivers/i3c/master/renesas-i3c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index 174d3dc5d276..275f7b924288 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -679,7 +679,7 @@ static int renesas_i3c_daa(struct i3c_master_controller *m)
> i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
> }
>
> - return ret < 0 ? ret : 0;
> + return 0;
> }
>
> static bool renesas_i3c_supports_ccc_cmd(struct i3c_master_controller *m,
> --
> 2.47.2
>
>
Thanks & Regards,
Tommaso
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2025-08-06 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-03 21:12 [PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa' Wolfram Sang
2025-08-04 8:57 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJB2E5wJ0gtIOy0f@tom-desktop \
--to=tommaso.merciai.xr@bp.renesas.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).