Re: [PATCH V2 10/13] i3c: mipi-i3c-hci-pci: Add exit callback

[Frank Li <Frank.li@nxp.com>]

On Fri, Nov 14, 2025 at 08:13:53PM +0200, Adrian Hunter wrote:
> Add ->exit() callback as a counterpart to ->init().  This is in
> preparation for adding device-specific features that require cleanup
> upon driver removal.

Prepare to add device-specific features ...

>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
>
> Changes in V2:
>
> 	Re-based
>
>
>  drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> index 7bfb9fe337b6..b962d3c2d510 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> @@ -17,10 +17,12 @@
>  struct mipi_i3c_hci_pci {
>  	struct pci_dev *pci;
>  	struct platform_device *pdev;
> +	const struct mipi_i3c_hci_pci_info *info;
>  };
>
>  struct mipi_i3c_hci_pci_info {
>  	int (*init)(struct mipi_i3c_hci_pci *hci);
> +	void (*exit)(struct mipi_i3c_hci_pci *hci);
>  };
>
>  static DEFINE_IDA(mipi_i3c_hci_pci_ida);
> @@ -72,7 +74,6 @@ static const struct mipi_i3c_hci_pci_info intel_info = {
>  static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
>  				  const struct pci_device_id *id)
>  {
> -	const struct mipi_i3c_hci_pci_info *info;
>  	struct mipi_i3c_hci_pci *hci;
>  	struct resource res[2];
>  	int dev_id, ret;
> @@ -114,9 +115,9 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
>  	if (ret)
>  		goto err;
>
> -	info = (const struct mipi_i3c_hci_pci_info *)id->driver_data;
> -	if (info && info->init) {
> -		ret = info->init(hci);
> +	hci->info = (const struct mipi_i3c_hci_pci_info *)id->driver_data;
> +	if (hci->info && hci->info->init) {
> +		ret = hci->info->init(hci);

This part's change does not belong to this patch.

Frank

>  		if (ret)
>  			goto err;
>  	}
> @@ -141,6 +142,9 @@ static void mipi_i3c_hci_pci_remove(struct pci_dev *pci)
>  	struct platform_device *pdev = hci->pdev;
>  	int dev_id = pdev->id;
>
> +	if (hci->info && hci->info->exit)
> +		hci->info->exit(hci);
> +
>  	platform_device_unregister(pdev);
>  	ida_free(&mipi_i3c_hci_pci_ida, dev_id);
>  }
> --
> 2.51.0
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c