From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i3c@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>,
Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [PATCH] i3c: Fix default I2C adapter timeout value
Date: Fri, 5 Sep 2025 10:38:03 +0300 [thread overview]
Message-ID: <aefc2b10-b014-49df-85c8-e7508935c19a@linux.intel.com> (raw)
In-Reply-To: <aLmfY3zznNHPvH4q@shikoro>
On 9/4/25 5:17 PM, Wolfram Sang wrote:
> On Thu, Sep 04, 2025 at 03:42:26PM +0300, Jarkko Nikula wrote:
>> Commit 3a379bbcea0a ("i3c: Add core I3C infrastructure") set the default
>> adapter timeout for I2C transfers as 1000 (ms). However that parameter
>> is defined in jiffies not in milliseconds.
>>
>> With mipi-i3c-hci driver this wasn't visible until commit c0a90eb55a69
>> ("i3c: mipi-i3c-hci: use adapter timeout value for I2C transfers").
>>
>> Fix this by setting the default timeout as HZ (CONFIG_HZ) not 1000.
>>
>> Fixes: 1b84691e7870 ("i3c: dw: use adapter timeout value for I2C transfers")
>> Fixes: be27ed672878 ("i3c: master: cdns: use adapter timeout value for I2C transfers")
>> Fixes: c0a90eb55a69 ("i3c: mipi-i3c-hci: use adapter timeout value for I2C transfers")
>> Fixes: a747e01adad2 ("i3c: master: svc: use adapter timeout value for I2C transfers")
>> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
>> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>
> Fixes: d028219a9f14 ("i3c: master: Add basic driver for the Renesas I3C controller")
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Thank you!
>
Ah, thanks! Somehow my eyes only saw the 1st call to the
wait_for_completion_timeout() in renesas-i3c.c passing
msecs_to_jiffies(1000) :-)
I didn't Cc stable since I don't think any of your patches cause any
other issue than extra long wait in case of I2C transfer error on
configurations where CONFIG_HZ is less than 1000 but now I'm unsure
should it be Cc'ed?
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-09-05 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 12:42 [PATCH] i3c: Fix default I2C adapter timeout value Jarkko Nikula
2025-09-04 14:17 ` Wolfram Sang
2025-09-05 7:38 ` Jarkko Nikula [this message]
2025-09-05 9:13 ` Wolfram Sang
2025-09-04 16:48 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aefc2b10-b014-49df-85c8-e7508935c19a@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox