Linux-i3c Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Jian-Ming Liao <tim678910@gmail.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@nxp.com,
	adrian.hunter@intel.com, jarkko.nikula@linux.intel.com,
	linux-i3c@lists.infradead.org, Jm_Liao@asmedia.com.tw,
	Chloe_Chen@asmedia.com.tw, Yd_Tseng@asmedia.com.tw,
	Patrick_Yen@asmedia.com.tw
Subject: Re: [PATCH 1/3] i3c: mipi-i3c-hci: Enable IBI threshold interrupt by default in PIO mode
Date: Thu, 9 Jul 2026 14:46:44 -0400	[thread overview]
Message-ID: <ak_slNTM4Y8ed7RN@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260709071744.333403-2-Jm_Liao@asmedia.com.tw>

On Thu, Jul 09, 2026 at 03:17:42PM +0800, Jian-Ming Liao wrote:
> Enable the IBI threshold interrupt (STAT_IBI_STATUS_THLD) by default
> during PIO initialization. This ensures that Hot-Join requests and
> early IBIs from devices that have not yet formally requested routing

Do you means not call i3c_device_request_ibi()?

Frank
> are properly captured, improving system responsiveness and stability.
>
> Co-developed-by: Patrick Yen <Patrick_Yen@asmedia.com.tw>
> Signed-off-by: Patrick Yen <Patrick_Yen@asmedia.com.tw>
> Signed-off-by: Jian-Ming Liao <Jm_Liao@asmedia.com.tw>
> ---
>  drivers/i3c/master/mipi-i3c-hci/pio.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/pio.c b/drivers/i3c/master/mipi-i3c-hci/pio.c
> index ff2657ee220b..7870b2c7888f 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/pio.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/pio.c
> @@ -185,8 +185,13 @@ static void __hci_pio_init(struct i3c_hci *hci, u32 *size_val_ptr)
>  	pio_reg_write(INTR_SIGNAL_ENABLE, 0x0);
>  	pio_reg_write(INTR_STATUS_ENABLE, 0xffffffff);
>
> -	/* Always accept error interrupts (will be activated on first xfer) */
> -	pio->enabled_irqs = STAT_ALL_ERRORS;
> +	/*
> +	 * Always accept error interrupts (will be activated on first xfer).
> +	 * Also enable IBI threshold interrupt by default to catch Hot-Join
> +	 * requests and IBIs from devices that haven't formally requested
> +	 * IBI routing yet.
> +	 */
> +	pio->enabled_irqs = STAT_ALL_ERRORS | STAT_IBI_STATUS_THLD;
>  }
>
>  static void hci_pio_suspend(struct i3c_hci *hci)
> --
> 2.43.0
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2026-07-09 18:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  7:17 [PATCH 0/3] i3c: mipi-i3c-hci: Add support for AMD_PT and improve IBI/PIO robustness Jian-Ming Liao
2026-07-09  7:17 ` [PATCH 1/3] i3c: mipi-i3c-hci: Enable IBI threshold interrupt by default in PIO mode Jian-Ming Liao
2026-07-09 18:46   ` Frank Li [this message]
2026-07-13 10:51     ` 廖建銘
2026-07-09  7:17 ` [PATCH 2/3] i3c: mipi-i3c-hci: Add PIO queue management support for HCI v1.2 Jian-Ming Liao
2026-07-09 18:57   ` Frank Li
2026-07-13 10:54     ` 廖建銘
2026-07-09  7:17 ` [PATCH 3/3] i3c: mipi-i3c-hci: Add support for AMD_PT I3C controller Jian-Ming Liao
2026-07-09 18:59   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ak_slNTM4Y8ed7RN@lizhi-Precision-Tower-5810 \
    --to=frank.li@oss.nxp.com \
    --cc=Chloe_Chen@asmedia.com.tw \
    --cc=Frank.Li@nxp.com \
    --cc=Jm_Liao@asmedia.com.tw \
    --cc=Patrick_Yen@asmedia.com.tw \
    --cc=Yd_Tseng@asmedia.com.tw \
    --cc=adrian.hunter@intel.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=tim678910@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox