From: Frank Li <Frank.li@oss.nxp.com>
To: junyi.zhao@amlogic.com
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, imx@lists.linux.dev,
linux-hardening@vger.kernel.org, xianwei.zhao@amlogic.com,
Kelvin.Zhang@amlogic.com,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support
Date: Mon, 16 Nov 2026 10:08:32 -0600 [thread overview]
Message-ID: <avsqgJczFes-NV2F@SMW015318> (raw)
In-Reply-To: <20261116-a9_i3c-v4-1-3d3222b7128d@amlogic.com>
On Mon, Nov 16, 2026 at 06:49:29PM +0800, Junyi Zhao via B4 Relay wrote:
> From: Junyi Zhao <junyi.zhao@amlogic.com>
>
> Amlogic A9 SoCs integrate the Silvaco I3C master IP in two domains:
> the EE-domain instance (amlogic,a9-i3c) takes "pclk" and "fast_clk"
> like the NXP integration, while the AO-domain instance
> (amlogic,a9-ao-i3c) lives in the Always-On domain and generates its
> bus clock from a divider inside the controller's own register space,
> so there is no external fast clock and only "pclk" is exposed.
>
> The two instances differ from the vanilla Silvaco/NXP integrations in
> clock topology and required init, so the driver matches them by
> dedicated compatibles instead of the "silvaco,i3c-master-v1"
> fallback: a fallback would bind the generic driver data, which
> neither programs the fast clock rate nor handles the AO internal
> divider, and the variant would then fail to work.
>
> Add both compatibles to the schema without the fallback, following
> nuvoton,npcm845-i3c, and use per-compatible if/then conditionals to
> enforce the clock counts: two clocks for the EE-domain instance and
> one clock for the AO-domain instance.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Junyi Zhao <junyi.zhao@amlogic.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../bindings/i3c/silvaco,i3c-master.yaml | 26 ++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index 853092f75..d892d42be 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -13,6 +13,8 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - amlogic,a9-i3c
> + - amlogic,a9-ao-i3c
> - nuvoton,npcm845-i3c
> - silvaco,i3c-master-v1
> - items:
> @@ -28,14 +30,14 @@ properties:
> maxItems: 1
>
> clocks:
> - minItems: 2
> + minItems: 1
> items:
> - description: system clock
> - description: bus clock
> - description: other (slower) events clock
>
> clock-names:
> - minItems: 2
> + minItems: 1
> items:
> - const: pclk
> - const: fast_clk
> @@ -70,15 +72,35 @@ allOf:
> compatible:
> contains:
> enum:
> + - amlogic,a9-i3c
> - nxp,imx94-i3c
> - nxp,imx95-i3c
> then:
> properties:
> clocks:
> + minItems: 2
> maxItems: 2
> clock-names:
> + minItems: 2
> maxItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,a9-ao-i3c
> + then:
> + properties:
> + clocks:
> + maxItems: 1
> + description:
> + The "ao" variant is the controller instance in the Always-On (AO)
> + domain, which has no separate bus clock and derives the
> + bus clock from an internal divider.
> + clock-names:
> + maxItems: 1
> +
> unevaluatedProperties: false
>
> examples:
>
> --
> 2.42.0
>
>
>
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-11-16 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:49 [PATCH v4 0/2] Add Amlogic A9 I3C support Junyi Zhao via B4 Relay
2026-11-16 10:49 ` [PATCH v4 1/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support Junyi Zhao via B4 Relay
2026-11-16 11:00 ` sashiko-bot
2026-11-16 16:08 ` Frank Li [this message]
2026-11-16 10:49 ` [PATCH v4 2/2] i3c: master: svc: Add amlogic a9 support Junyi Zhao via B4 Relay
2026-11-16 11:12 ` sashiko-bot
2026-11-16 16:28 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avsqgJczFes-NV2F@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=Kelvin.Zhang@amlogic.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=junyi.zhao@amlogic.com \
--cc=kees@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox