From: Krzysztof Kozlowski <krzk@kernel.org>
To: Steven Niu <steven.niu.uj@renesas.com>, alexandre.belloni@bootlin.com
Cc: zbigniew.lukwinski@linux.intel.com, linux-i3c@lists.infradead.org
Subject: Re: [PATCH v2 2/2] i3c: Add driver for i3c-hub device
Date: Thu, 18 Sep 2025 09:10:03 +0900 [thread overview]
Message-ID: <bdfaa495-2cfd-4453-ada9-109d184a47ed@kernel.org> (raw)
In-Reply-To: <20250917142055.2806576-2-steven.niu.uj@renesas.com>
On 17/09/2025 23:20, Steven Niu wrote:
> +
> +static struct device_node *i3c_hub_get_dt_hub_node(struct i3c_hub *hub)
> +{
> + struct device_node *node = hub->i3cdev->dev.parent->of_node;
> + struct device_node *matched_node = NULL;
> + int max_ids_matched;
> + struct device_node *hub_node, *from;
> + int node_ids_matched;
> + u8 dcr;
> + u32 id_csel, id_cp1, id_tpx;
> + int ret;
> +
> + max_ids_matched = 0;
> +
> + hub_node = NULL;
> + from = node;
> + while (1) {
> + hub_node = of_find_node_by_name(from, "hub");
Which part of previous NAK was not clear?
You ignored also review on patch #1, so now I question myself whether we
should even bother looking here.
Best regards,
Krzysztof
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-09-18 0:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 13:14 [PATCH 1/2] dt-bindings: i3c-hub: Add Renesas RG3MxxB12A1 I3C HUB Steven Niu
2024-02-17 13:14 ` [PATCH 2/2] i3c: i3c-hub: Add Renesas RG3MxxB12A1 I3C HUB driver Steven Niu
2024-02-17 13:58 ` Krzysztof Kozlowski
2024-06-19 6:55 ` Jeremy Kerr
2024-07-24 11:47 ` Steven Niu
2024-07-25 1:52 ` Jeremy Kerr
2024-02-17 13:53 ` [PATCH 1/2] dt-bindings: i3c-hub: Add Renesas RG3MxxB12A1 I3C HUB Krzysztof Kozlowski
2024-02-17 13:57 ` Krzysztof Kozlowski
2024-02-17 14:07 ` Krzysztof Kozlowski
2024-02-17 14:55 ` Rob Herring
2025-09-17 14:20 ` [PATCH v2 1/2] dt-bindings: i3c: Add i3c-hub support Steven Niu
2025-09-17 14:20 ` [PATCH v2 2/2] i3c: Add driver for i3c-hub device Steven Niu
2025-09-18 0:10 ` Krzysztof Kozlowski [this message]
2025-09-17 16:59 ` [PATCH v2 1/2] dt-bindings: i3c: Add i3c-hub support Frank Li
2025-09-18 0:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdfaa495-2cfd-4453-ada9-109d184a47ed@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=steven.niu.uj@renesas.com \
--cc=zbigniew.lukwinski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).