From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] i3c/master: cmd_v1: Fix the rule for getting i3c mode
Date: Thu, 5 Sep 2024 11:20:29 +0530 [thread overview]
Message-ID: <cc94e66f-6fa0-4499-a851-bac90533eeca@quicinc.com> (raw)
In-Reply-To: <OSQPR06MB7252463A7C81BF18811DB6EC8B8B2@OSQPR06MB7252.apcprd06.prod.outlook.com>
Hi Billy,
On 8/26/2024 9:32 AM, Billy Tsai wrote:
>> Based on the I3C TCRI specification, the rules for determining the I3C
>> mode are as follows:
>> I3C SCL rate > 8MHz: use SDR0, with a maximum data rate of 8MHz
>> I3C SCL rate > 6MHz: use SDR1, with a maximum data rate of 6MHz
>> I3C SCL rate > 4MHz: use SDR2, with a maximum data rate of 4MHz
>> I3C SCL rate > 2MHz: use SDR3, with a maximum data rate of 2MHz
>> Otherwise, use SDR4
>
> Sorry, the description of the commit message is wrong.
> I will change it to
> I3C SCL rate > 8MHz: use SDR0, as SDR1 has a maximum data rate of 8MHz
> I3C SCL rate > 6MHz: use SDR1, as SDR2 has a maximum data rate of 8MHz
> I3C SCL rate > 4MHz: use SDR2, as SDR3 has a maximum data rate of 8MHz
> I3C SCL rate > 2MHz: use SDR3, as SDR4 has a maximum data rate of 8MHz
> I3C SCL rate <= 2MHz: use SDR4
> and send the v2 patch
Seems some typo errors, you mentioned all the modes having maximum data
rate of 8MHz. "has a maximum data rate of 8MHz"
I3C TCRI Specification (in [MIPI06] Section 7.1.1.1) :
MODE Listed Speed Maximum Sustainable Data Rate
0x0 I3C SDR0 12.5 MHz, Standard SDR Speed, fSCL Max
0x1 I3C SDR1 8 MHz
0x2 I3C SDR2 6 MHz
0x3 I3C SDR3 4 MHz
0x4 I3C SDR4 2 MHz
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2024-09-05 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 3:38 [PATCH v1] i3c/master: cmd_v1: Fix the rule for getting i3c mode Billy Tsai
2024-08-26 4:02 ` Billy Tsai
2024-09-05 5:50 ` Mukesh Kumar Savaliya [this message]
2024-09-06 15:38 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc94e66f-6fa0-4499-a851-bac90533eeca@quicinc.com \
--to=quic_msavaliy@quicinc.com \
--cc=alexandre.belloni@bootlin.com \
--cc=billy_tsai@aspeedtech.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox