From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: cvam <cvam0000@gmail.com>, alexandre.belloni@bootlin.com
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: TODO : i3c/master/mipi-i3c-hci/dma.c
Date: Mon, 30 Sep 2024 16:02:46 +0300 [thread overview]
Message-ID: <d0de10c7-bd99-4b81-aa11-5039c514eefc@linux.intel.com> (raw)
In-Reply-To: <CADVSkwnC6b3irLx58YRGJayw09AvVUqmN=3_b35vdhJKFpsgog@mail.gmail.com>
Hi
On 9/28/24 9:39 PM, cvam wrote:
> Hello Alexandre
>
> This mail is regarding TODO present in the i3c/master/mipi-i3c-hci/dma.c, i
> would like to work on it, please give some more info what exactly we are
> referring here.
>
>
> dev_err(&hci->master.dev,
> "response tid=%d when expecting
> %d\n",
> tid, xfer->cmd_tid);
> /* TODO: do something about it? */
> }
> if (xfer->completion)
> complete(xfer->completion);
>
Well source code has minimum handling for unexpected but uncertain what
to do about it. In my opinion "TODO" is a fair comment about it.
I'd leave it as it until somebody sees it on real and then we can debug
does it need some steps in HW/SW point of view to recover.
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
parent reply other threads:[~2024-09-30 13:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CADVSkwnC6b3irLx58YRGJayw09AvVUqmN=3_b35vdhJKFpsgog@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0de10c7-bd99-4b81-aa11-5039c514eefc@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=cvam0000@gmail.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).