From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Liao Chen <liaochen4@huawei.com>, <linux-i3c@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <pgaj@cadence.com>, <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH -next] i3c: master: cdns: fix module autoloading
Date: Thu, 29 Aug 2024 12:09:34 +0530 [thread overview]
Message-ID: <f5faa10a-25e6-4793-99ad-dbcfe0ffee8b@quicinc.com> (raw)
In-Reply-To: <20240826123957.379212-1-liaochen4@huawei.com>
On 8/26/2024 6:09 PM, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
>
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
> drivers/i3c/master/i3c-master-cdns.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> index c1627f3552ce..ee555255f1a2 100644
> --- a/drivers/i3c/master/i3c-master-cdns.c
> +++ b/drivers/i3c/master/i3c-master-cdns.c
> @@ -1562,6 +1562,7 @@ static const struct of_device_id cdns_i3c_master_of_ids[] = {
> { .compatible = "cdns,i3c-master", .data = &cdns_i3c_devdata },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, cdns_i3c_master_of_ids);
>
why not to use i3c as type instead of "of" ? Just curious, if it makes
sense.
> static int cdns_i3c_master_probe(struct platform_device *pdev)
> {
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2024-08-29 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 12:39 [PATCH -next] i3c: master: cdns: fix module autoloading Liao Chen
2024-08-29 6:39 ` Mukesh Kumar Savaliya [this message]
2024-09-05 16:46 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5faa10a-25e6-4793-99ad-dbcfe0ffee8b@quicinc.com \
--to=quic_msavaliy@quicinc.com \
--cc=alexandre.belloni@bootlin.com \
--cc=liaochen4@huawei.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgaj@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox