From: "Ng, Adrian Ho Yin" <adrianhoyin.ng@altera.com>
To: Frank Li <Frank.li@nxp.com>
Cc: alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry count
Date: Tue, 25 Nov 2025 11:19:58 +0800 [thread overview]
Message-ID: <f5ff6901-ada5-47ce-822d-11aa35adabc9@altera.com> (raw)
In-Reply-To: <aSSdEW4/WCpGxJ/o@lizhi-Precision-Tower-5810>
On 11/25/2025 1:59 AM, Frank Li wrote:
>> +
>> + master->dev_nack_retry_cnt = val;
>> +
>> + spin_lock_irqsave(&master->devs_lock, flags);
>
> I think you'd better to hold i3c_bus_maintenance_lock() lock to make
> sure not transfer on going.
>
> Frank
Hi Frank
i3c_bus_maintenance_lock is a static function in master.c. So should i
update it and expose a public helper to take the maintenance lock or
continue using the existing spin lock to protect the DAT updates?
Thank You
Adrian
>> + /*
>> + * Update DAT entries for all currently attached devices.
>> + * We directly iterate through the master's device array.
>> + */
>> + for (i = 0; i < master->maxdevs; i++) {
>> + /* Skip free/empty slots */
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-11-25 3:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 18:00 [PATCH v3 0/3] i3c: dw-i3c: Enable support for dw-i3c controller NACK retry sysfs and DAT restore fix adrianhoyin.ng
2025-11-21 18:00 ` [PATCH v3 1/3] i3c: add sysfs entry for Device NACK Retry count adrianhoyin.ng
2025-11-24 17:47 ` Frank Li
2025-11-21 18:00 ` [PATCH v3 2/3] i3c: dw: Add sysfs support " adrianhoyin.ng
2025-11-24 17:59 ` Frank Li
2025-11-25 3:19 ` Ng, Adrian Ho Yin [this message]
2025-11-25 14:05 ` Adrian Hunter
2025-11-25 17:07 ` Frank Li
2025-11-21 18:00 ` [PATCH v3 3/3] i3c: dw: Preserve DAT entry bits when restoring addresses adrianhoyin.ng
2025-11-24 18:06 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ff6901-ada5-47ce-822d-11aa35adabc9@altera.com \
--to=adrianhoyin.ng@altera.com \
--cc=Frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox