public inbox for linux-i3c@lists.infradead.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Ben Dooks <ben.dooks@sifive.com>, linux-i3c@lists.infradead.org
Cc: devicetree@vger.kernel.org,
	Matt Johnston <matt@codeconstruct.com.au>,
	 Vitor Soares <ivitro@gmail.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jack Chen <zenghuchen@google.com>,
	Billy Tsai <billy_tsai@aspeedtech.com>,
	Dylan Hung <dylan_hung@aspeedtech.com>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v2 3/3] i3c: ast2600: Add AST2600 platform-specific driver
Date: Fri, 31 Mar 2023 10:04:40 +0800	[thread overview]
Message-ID: <fa6ff04cbbbb126e6902757d668301092d7320ae.camel@codeconstruct.com.au> (raw)
In-Reply-To: <b6d88196-aafc-4880-9de3-7725e253cfa7@sifive.com>

Hi Ben,

Thanks for the review. Comments inline:

> How about wrapping the dw_i3c_master struct in an as2600_master struct
> and then you can use container of, and simply do sizeof(struct
> ast2600_master) ?
> 
> Also removes the need below to set pdata at-all

Yep, sounds good, and avoids my quirky pointer arithmetic below that.

> > +static struct platform_driver ast2600_i3c_driver = {
> > +       .probe = ast2600_i3c_probe,
> > +       .remove = ast2600_i3c_remove,
> > +       .driver = {
> > +               .name = "ast2600-i3c-master",
> > +               .of_match_table =
> > of_match_ptr(ast2600_i3c_master_of_match),
> 
> given this is probably an of-device only, of_match_ptr not needed
> here?

Ack, will remove.

Thanks,


Jeremy

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2023-03-31  2:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  7:22 [PATCH v2 0/3] i3c dw,ast2600: Add a driver for the AST2600 i3c controller Jeremy Kerr
2023-03-30  7:22 ` [PATCH v2 1/3] i3c: dw: Add infrastructure for platform-specific implementations Jeremy Kerr
2023-03-30  7:22 ` [PATCH v2 2/3] dt-bindings: i3c: Add AST2600 i3c controller Jeremy Kerr
2023-03-30 10:02   ` Krzysztof Kozlowski
2023-03-30  7:22 ` [PATCH v2 3/3] i3c: ast2600: Add AST2600 platform-specific driver Jeremy Kerr
2023-03-30 19:22   ` Ben Dooks
2023-03-31  2:04     ` Jeremy Kerr [this message]
2023-03-30 14:43 ` [PATCH v2 0/3] i3c dw,ast2600: Add a driver for the AST2600 i3c controller Jack Chen
2023-03-31  2:33   ` Jeremy Kerr
2023-03-31  7:44     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa6ff04cbbbb126e6902757d668301092d7320ae.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@aj.id.au \
    --cc=ben.dooks@sifive.com \
    --cc=billy_tsai@aspeedtech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dylan_hung@aspeedtech.com \
    --cc=ivitro@gmail.com \
    --cc=joel@jms.id.au \
    --cc=linux-i3c@lists.infradead.org \
    --cc=matt@codeconstruct.com.au \
    --cc=zenghuchen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox