From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [Patch] Don't alloc empty frame in ia64_switch_mode_phys
Date: Wed, 26 Jul 2006 15:33:35 +0000 [thread overview]
Message-ID: <000001c6b0c8$e0f3a710$6154e984@amr.corp.intel.com> (raw)
In-Reply-To: <1153870600.3286.72.camel@linux-znh>
Zou Nan hai wrote on Tuesday, July 25, 2006 4:37 PM
> I think ia64_switch_mode_phys and ia64_switch_mode_virt
> does not need to alloc an empty frame.
> An empty frame is required by loadrs but flushrs
> does not need that.
This patch would make your previous "Do not assume output registers
be reservered" unnecessary, isn't it? It will automatically solve
the problem you are trying to fix in previous patch.
The real issue to me is that ia64_switch_mode_phys() creates a zero
stack frame before turning off interrupt. If the zero frame alloc
instruction is removed, the current register stack frame ought to be
safe because they should be preserved by the interrupt return path.
- Ken
next prev parent reply other threads:[~2006-07-26 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 23:36 [Patch] Don't alloc empty frame in ia64_switch_mode_phys Zou Nan hai
2006-07-26 15:33 ` Chen, Kenneth W [this message]
2006-07-26 21:08 ` Zou Nan hai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001c6b0c8$e0f3a710$6154e984@amr.corp.intel.com' \
--to=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox