From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [PATCH] IA64 trap code 16 bytes atomic copy on montecito
Date: Tue, 31 Oct 2006 08:09:18 +0000 [thread overview]
Message-ID: <000201c6fcc3$dd5e60d0$5181030a@amr.corp.intel.com> (raw)
In-Reply-To: <4546E55E.3050207@intel.com>
Keith Owens wrote on Monday, October 30, 2006 10:18 PM
> >+GLOBAL_ENTRY(kprobe_update_inst_bundle)
> >+ alloc loc0=ar.pfs,3,1,0,0
> >+
> >+ and r15\x15,r34
> >+ and r14\x15,r33
>
> Use in0, in1, in2, not r32-34.
Also there is no need to resize the register stack frame here, since
this is already a leaf function and there are plenty scratch register
you can use before tap into register stack. I personally prefer not
to do alloc instruction here.
And I think it would be a lot easier if you implement an intrinsic
function, like ia64_ld16/ia64_st16 and stick them in include/asm-ia64/
gcc_intrin.h and intel_intrin.h.
next prev parent reply other threads:[~2006-10-31 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 5:55 [PATCH] IA64 trap code 16 bytes atomic copy on montecito bibo,mao
2006-10-31 6:18 ` Keith Owens
2006-10-31 7:53 ` Chen, Kenneth W
2006-10-31 8:09 ` Chen, Kenneth W [this message]
2006-10-31 8:19 ` bibo,mao
2006-10-31 8:40 ` Chen, Kenneth W
2006-10-31 12:48 ` bibo,mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201c6fcc3$dd5e60d0$5181030a@amr.corp.intel.com' \
--to=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox