From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: salinfo-0.4 patch
Date: Wed, 28 Jan 2004 21:50:57 +0000 [thread overview]
Message-ID: <10165.1075326657@ocs3.ocs.com.au> (raw)
In-Reply-To: <1075324928.25461.273.camel@xenophanes>
On 28 Jan 2004 13:22:08 -0800,
Ben Woodard <woodard@redhat.com> wrote:
>Here is a tiny patch for salinfo-0.4. There is a problem with when it
>deals with multiple errors. The decoded error messages fill up with
>progressively more white space.
That should not occur, the ++indent/--indent lines should be matched.
Instead of forcing indent back to 0, please find the missing line and
fix it. Correct code is better than an arbitrary reset.
If you have a sample of nested indent that will help track down the
bug, send it to kaos@sgi.com.
>While poking around in the iprint function, I also found an error
>message that looks like it is better suited for stderr rather than
>stdout so I retargetted it.
No. I deliberately used stdout so the error message would appear at
the end of the truncated file on disk, to tell the viewer that this
particular file was incomplete. stderr is useless when salinfo_decode
is run from init.d.
next prev parent reply other threads:[~2004-01-28 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 21:22 salinfo-0.4 patch Ben Woodard
2004-01-28 21:50 ` Keith Owens [this message]
2004-01-28 23:32 ` Ben Woodard
2004-01-30 2:36 ` Ben Woodard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10165.1075326657@ocs3.ocs.com.au \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox