public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Bob Montgomery <bob.montgomery@hp.com>
To: linux-ia64@vger.kernel.org
Subject: unwabi mismatch in 2.4.X kernels breaks oops call trace (unwind)
Date: Tue, 10 Feb 2004 00:48:57 +0000	[thread overview]
Message-ID: <1076374136.10372.3.camel@peas.bobm> (raw)

Oops stack unwinding was broken in 2.4.22 by this patch that was
picked up from 2.5/2.6:
                               
--- 1.5/arch/ia64/kernel/entry.h	Mon Feb  9 13:41:40 2004
+++ 1.6/arch/ia64/kernel/entry.h	Mon Feb  9 13:41:40 2004
@@ -14,7 +14,7 @@
 #define SW(f)		(IA64_SWITCH_STACK_##f##_OFFSET)
 
 #define PT_REGS_SAVES(off)			\
-	.unwabi @svr4, 'i';			\
+	.unwabi 3, 'i';				\
 	.fframe IA64_PT_REGS_SIZE+16+(off);	\
 	.spillsp rp, PT(CR_IIP)+16+(off);	\
 	.spillsp ar.pfs, PT(CR_IFS)+16+(off);	\


If we want to keep this change in 2.4.X, we need to also change the
test in desc_abi (unwind.c) to check for abi = 3 instead of 0.

static inline void
desc_abi (unsigned char abi, unsigned char context, struct unw_state_record *sr){
        if (abi = 0 && context = 'i') {
                sr->flags |= UNW_FLAG_INTERRUPT_FRAME;
                UNW_DPRINT(3, "unwind.%s: interrupt frame\n", __FUNCTION__);
        }
        else
                UNW_DPRINT(0, "unwind%s: ignoring unwabi(abi=0x%x,context=0x%x)\n",
                                __FUNCTION__, abi, context);
}

Otherwise we can just back the entry.h patch out.  So my question
is: Is there a compelling reason to change the abi number from 0 to
3 in 2.4.X kernels?  Is there an outside tool that cares, or is it
sufficient for these two snippets of kernel code to merely agree on
some number?

Thanks,
Bob Montgomery



             reply	other threads:[~2004-02-10  0:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-10  0:48 Bob Montgomery [this message]
2004-02-10  1:28 ` unwabi mismatch in 2.4.X kernels breaks oops call trace (unwind) David Mosberger
2004-02-10 20:43 ` Bjorn Helgaas
2004-02-10 20:56 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1076374136.10372.3.camel@peas.bobm \
    --to=bob.montgomery@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox