From: Alex Williamson <alex.williamson@hp.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] trashing bootmem on non-NUMA boxes
Date: Fri, 25 Jun 2004 16:12:16 +0000 [thread overview]
Message-ID: <1088179936.4106.15.camel@tdi> (raw)
call_pernode_memory() is rounding memory regions to page boundaries,
but in the non-NUMA case, it's incorrectly passing the rounded start and
the original length. Any reserved memory regions sitting beyond a
memory region that isn't nicely aligned is potentially at risk for
getting freed and trashed. This is a fairly nasty bug that can bite in
very hard to find ways. In my case, the EFI memory map was getting
overwritten, causing the ACPI methods to access chipset registers
cachable instead of uncachable. It could potentially be causing some of
the random hangs and strange behavior we're seeing lately.
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
=== arch/ia64/mm/discontig.c 1.15 vs edited ==--- 1.15/arch/ia64/mm/discontig.c Thu Jun 24 02:55:57 2004
+++ edited/arch/ia64/mm/discontig.c Fri Jun 25 09:39:20 2004
@@ -549,7 +549,7 @@
if (!num_node_memblks) {
/* No SRAT table, so assume one node (node 0) */
if (start < end)
- (*func)(start, len, 0);
+ (*func)(start, end - start, 0);
return;
}
reply other threads:[~2004-06-25 16:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088179936.4106.15.camel@tdi \
--to=alex.williamson@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox