From: Rusty Russell <rusty@rustcorp.com.au>
To: Takao Indoh <indou.takao@soft.fujitsu.com>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH 1/5][Diskdump] IPF(IA64) support
Date: Fri, 15 Oct 2004 01:35:22 +0000 [thread overview]
Message-ID: <1097804121.22673.43.camel@localhost.localdomain> (raw)
In-Reply-To: <15C4709AD81CB1indou.takao@soft.fujitsu.com>
On Fri, 2004-07-23 at 19:53, Takao Indoh wrote:
> +static unsigned int fallback_on_err = 1;
> +static unsigned int allow_risky_dumps = 1;
> +static unsigned int block_order = 2;
> +static int sample_rate = 8;
> +module_param(fallback_on_err, uint, 0);
> +module_param(allow_risky_dumps, uint, 0);
> +module_param(block_order, uint, 0);
> +module_param(sample_rate, int, 0);
Hi Takao!
Are you sure you want "uint" for fallback_on_err and allow_risky_dumps
and not "bool"? Also, I suggest "0400" as permissions so you can read
them out of sysfs; maybe even 0600 if these parameters can be changed
after loading.
Thanks!
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-10-15 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 9:51 [PATCH 0/5][Diskdump] IPF(IA64) support Takao Indoh
2004-07-23 9:53 ` [PATCH 1/5][Diskdump] " Takao Indoh
2004-10-15 1:35 ` Rusty Russell [this message]
2004-10-15 2:11 ` Takao Indoh
2004-07-23 9:54 ` [PATCH 2/5][Diskdump] " Takao Indoh
2004-07-23 9:55 ` [PATCH 3/5][Diskdump] " Takao Indoh
2004-07-23 9:56 ` [PATCH 4/5][Diskdump] " Takao Indoh
2004-07-23 9:58 ` [PATCH 5/5][Diskdump] " Takao Indoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097804121.22673.43.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=indou.takao@soft.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox