Re: page fault scalability patch V11 [0/7]: overview

Nick Piggin
2004-11-20T04:03:17Z

William Lee Irwin III wrote:
> William Lee Irwin III wrote:
>
>>>Unprivileged triggers for full-tasklist scans are NMI oops material.
>
>
> On Sat, Nov 20, 2004 at 02:37:04PM +1100, Nick Piggin wrote:
>
>>Hang on, let's come back to this...
>>We already have unprivileged do-for-each-thread triggers in the proc
>>code. It's in do_task_stat, even. Rss reporting would basically just
>>involve one extra addition within that loop.
>>So... hmm, I can't see a problem with it.
>
>
> /proc/ triggering NMI oopses was a persistent problem even before that
> code was merged. I've not bothered testing it as it at best aggravates it.
>

It isn't a problem. If it ever became a problem then we can just
touch the nmi oopser in the loop.

> And thread groups can share mm's. do_for_each_thread() won't suffice.
>

I think it will be just fine.