Re: [patch -mm series] ia64 specific /dev/mem handlers

Jes Sorensen
2005-02-22T21:34:23Z

>>>>> "Andrew" = Andrew Morton <akpm@osdl.org> writes:

Andrew> Matthew Wilcox <matthew@wil.cx> wrote:
>>
>> On Tue, Feb 22, 2005 at 09:41:04AM -0500, Jes Sorensen wrote:
>> > >> + if (page->flags & PG_uncached)
>> >
>> > Andrew> dude. That ain't gonna work ;)
>> >
>> > Pardon my lack of clue, but why not?

Andrew> if (page->flags & (1<<PG_uncached))

Andrew> would have been correcter.

DOH!

Desperately seeking a bulk supply of those brown paper bags!

>> I think you're supposed to always use test_bit() to check page
>> flags

Andrew> Yup. Add PageUncached macros to page-flags.h.

Mmmmm another butt ugly StUdLyCaPs macro coming soon.

Thanks,
Jes