Re: [PATCH/RFC] I/O-check interface for driver's error handling

Jesse Barnes
2005-03-02T18:41:06Z

On Wednesday, March 2, 2005 10:22 am, Linas Vepstas wrote:
> On Tue, Mar 01, 2005 at 08:49:45AM -0800, Linus Torvalds was heard to
remark:
> > The new API is what _allows_ a driver to care. It doesn't handle DMA, but
> > I think that's because nobody knows how to handle it (ie it's probably
> > hw-dependent and all existign implementations would thus be
> > driver-specific anyway).
>
> ?
> We could add a call
>
> int pci_was_there_an_error_during_dma (struct pci_dev);
>
> right? And it could return true/false, right? I can certainly
> do that today with ppc64. I just can't tell you which dma triggered
> the problem.

One issue with that is how to notify drivers that they need to make this call.
In may cases, DMA completion will be signalled by an interrupt, but if the
DMA failed, that interrupt may never happen, which means the call to
pci_unmap or the above function from the interrupt handler may never occur.

Some I/O errors are by nature asynchronous and unpredictable, so I think we
need a separate thread and callback interface to deal with errors where the
beginning of the transaction and the end of the transaction occur in
different contexts, in addition to the PIO transaction interface already
proposed.

Jesse