From: dann frazier <dannf@dannf.org>
To: linux-ia64@vger.kernel.org
Subject: Re: conflicting per_cpu_init() defines on non-SMP
Date: Sun, 13 Mar 2005 22:16:29 +0000 [thread overview]
Message-ID: <1110752189.28262.3.camel@localhost> (raw)
In-Reply-To: <1110344998.9344.9.camel@localhost>
On Wed, 2005-03-09 at 09:38 -0800, Grant Grundler wrote:
> On Tue, Mar 08, 2005 at 10:09:58PM -0700, dann frazier wrote:
> > Is this the right way to approach a patch to fix this?
>
> It looks right. But I'd expect arch/ia64/mm/discontig.c to use whats
> in the header file so everyone is using the same definition.
>
> > +#ifdef CONFIG_SMP
> > void *per_cpu_init(void)
> ...
>
> ie move that bit to asm-ia64/percpu.h
Thanks Grant.
I took a closer look at Jesse's fixes, and he had already solved this in
a different way. I'll stick with his method.
--
dann frazier <dannf@dannf.org>
prev parent reply other threads:[~2005-03-13 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-09 5:09 conflicting per_cpu_init() defines on non-SMP dann frazier
2005-03-09 17:38 ` Grant Grundler
2005-03-13 22:16 ` dann frazier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110752189.28262.3.camel@localhost \
--to=dannf@dannf.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox