From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: tony.luck@intel.com,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, hugh@veritas.com
Subject: Re: bad pgd/pmd in latest BK on ia64
Date: Tue, 15 Mar 2005 07:17:27 +0000 [thread overview]
Message-ID: <1110871047.29138.92.camel@gaston> (raw)
In-Reply-To: <20050314153156.159d4bb3.davem@davemloft.net>
On Mon, 2005-03-14 at 15:31 -0800, David S. Miller wrote:
> On Mon, 14 Mar 2005 15:11:42 -0800
> "David S. Miller" <davem@davemloft.net> wrote:
>
> > I therefore suspect the pgwalk patches.
>
> I just noticed something else while reviewing this stuff.
> The PTRS_PER_PMD macros aren't used anymore, so my hacks
> to get 32-bit process VM operations optimized on sparc64
> aren't even being used any more, ho hum... :-) There are
> better ways to do this.
>
> (For the interested, see {REAL_}PTRS_PER_PMD in
> include/asm-sparc64/pgtable.h)
>
> Come to think of it, this may be related somehow to whatever
> is causing the problems.
That reminds me ... I still itend to toy with your old patches and add
some more abstract walkers & bitmap stuffs. Just no time at the moment.
The main thing I want to change from your approach is instead of calling
a pte_work callback for every pte, call it for ranges of PTEs (that is
PTE pages most of the time). The goal here is to avoid the overhead of
the indirect function call (& additional stackframe junk etc...) on
every single PTE.
Ben.
next prev parent reply other threads:[~2005-03-15 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 22:06 bad pgd/pmd in latest BK on ia64 Luck, Tony
2005-03-14 22:34 ` David S. Miller
2005-03-14 23:11 ` David S. Miller
2005-03-14 23:31 ` David S. Miller
2005-03-15 7:17 ` Benjamin Herrenschmidt [this message]
2005-03-15 13:24 ` Martin Hicks
2005-03-15 18:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110871047.29138.92.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox