From: Khalid Aziz <khalid_aziz@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] /proc/iomem update
Date: Fri, 29 Jul 2005 19:40:06 +0000 [thread overview]
Message-ID: <1122666006.20867.38.camel@lyra.fc.hp.com> (raw)
In-Reply-To: <E1DyZJE-0006Au-00@lyra.fc.hp.com>
That "continue" is intentional and you are right, it will cause memory
leak. It should be preceded by kfree(res). I will fix that.
Thanks,
Khalid
On Fri, 2005-07-29 at 11:22 -0700, david mosberger wrote:
> Is the "continue" here spurious? If not, it would cause
> memory-leaking since "res" has been allocated already.
>
> + case EFI_MEMORY_MAPPED_IO:
> + case EFI_MEMORY_MAPPED_IO_PORT_SPACE:
> + continue;
> + break;
>
> --david
--
==================================
Khalid Aziz Open Source and Linux Organization
(970)898-9214 Hewlett-Packard
khalid.aziz@hp.com Fort Collins, CO
"The Linux kernel is subject to relentless development"
- Alessandro Rubini
prev parent reply other threads:[~2005-07-29 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 18:10 [PATCH] /proc/iomem update Khalid Aziz
2005-07-29 18:22 ` david mosberger
2005-07-29 19:40 ` Khalid Aziz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1122666006.20867.38.camel@lyra.fc.hp.com \
--to=khalid_aziz@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox