From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Date: Fri, 12 Aug 2005 08:35:50 +0000 Subject: Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64 Message-Id: <1123835751.22460.13.camel@localhost.localdomain> List-Id: References: <200508111424.43150.bjorn.helgaas@hp.com> <20050811214807.GA9775@havoc.gtf.org> <42FBC985.4030602@pobox.com> <200508111707.30861.bjorn.helgaas@hp.com> In-Reply-To: <200508111707.30861.bjorn.helgaas@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas Cc: Jeff Garzik , B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-ia64@vger.kernel.org, Tony Luck On Iau, 2005-08-11 at 17:07 -0600, Bjorn Helgaas wrote: > So the scenario in question (correct me if I'm wrong) is that we > have a PCI IDE device that is handed off in compatibility mode (and > may only work in that mode). In that case, the PCI *device* still > exists, so shouldn't the IDE PCI code claim that device, notice that > it's in compatibility mode, and use the legacy ports and IRQs if > necessary? The PCI IDE code and legacy IDE code both find the device and they realise its the same device so that it is driven by a suitable driver. The legacy IDE driver is useful if your platform has an unsupported IDE controller. It seems ot me the correct fix for IA64 is probably to set your arch specific probe address function to only probe the standard PCI legacy ports and to do any other appropriate checks, not to take an axe to Kconfig. Alan