From: Zou Nan hai <nanhai.zou@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: Attribute spinlock contention ticks to caller.
Date: Thu, 15 Sep 2005 22:54:43 +0000 [thread overview]
Message-ID: <1126824883.2523.14.camel@linux-znh> (raw)
In-Reply-To: <20050914222644.GA5036@lnx-holt.americas.sgi.com>
On Fri, 2005-09-16 at 01:37, Luck, Tony wrote:
> >This also opens the door for people submitted other special cases.
>
> I'm very sympathetic to getting better performance data. I agree
> 100% that knowing who called spinlock contention is far better than
> just lumping all spinlock contention together.
>
> But I have to agree with Stephane that this looks like the start
> of a slippery slope of special cases (each of which provides two
> new exported symbols).
>
> We should look to see if there is a better way to flag address
> ranges in the kernel where you'd like to bill time to the caller
> rather than the function (perhaps some sort of tag table like the
> extable used for copyin/copyout fault recovery? Then we can just
> export one table and have the profiler search it ... rather than
> a new pair of symbols for every case.
>
> Or you can try to convince me that spinlock contention is such
> a special one off case, and we will never, ever, want to do this
> anywhere else.
>
> -Tony
There is a function in_lock_function in kernel/spinlock.c
However in latest kernel, ia64_spinlock_contention is not in
.spinlock.text section.
We could first collect ia64_spinlock_contention into .spinlock.text
section. Then use in_lock_function.
Zou Nan hai
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2005-09-15 22:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 22:26 Attribute spinlock contention ticks to caller Robin Holt
2005-09-15 0:10 ` Keith Owens
2005-09-15 6:34 ` Stephane Eranian
2005-09-15 8:19 ` Stephane Eranian
2005-09-15 17:14 ` Robin Holt
2005-09-15 17:23 ` Robin Holt
2005-09-15 17:37 ` Luck, Tony
2005-09-15 22:29 ` Robin Holt
2005-09-15 22:54 ` Zou Nan hai [this message]
2005-09-16 9:37 ` Stephane Eranian
2005-09-16 22:29 ` Robin Holt
2005-09-17 1:08 ` David Mosberger-Tang
2005-09-18 23:06 ` Robin Holt
2005-09-19 1:18 ` David Mosberger-Tang
2005-09-19 8:35 ` Stephane Eranian
2005-09-19 15:17 ` Robin Holt
2005-09-19 17:52 ` David Mosberger-Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126824883.2523.14.camel@linux-znh \
--to=nanhai.zou@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox