From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Date: Fri, 06 Jan 2006 19:21:36 +0000 Subject: Re: [PATCH] Simple memory hot-add for ia64. Message-Id: <1136575296.8189.25.camel@localhost.localdomain> List-Id: References: <20060106114249.5649.Y-GOTO@jp.fujitsu.com> In-Reply-To: <20060106114249.5649.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yasunori Goto Cc: "Luck, Tony" , Linux Hotplug Memory Support , linux-ia64@vger.kernel.org, Linux Kernel ML , linux-mm , Bob Picco , Mike Kravetz On Fri, 2006-01-06 at 11:50 +0900, Yasunori Goto wrote: > Fortunately, 2.6.15 includes memory hot-add function for i386 and ppc. > So, I made a patch for ia64. > This doesn't make new pgdat. All of new memory will belong to > node 0 by this patch. But this is simplest first step and best start for > future work. It does look quite simple. Nice work. > +#ifdef CONFIG_MEMORY_HOTPLUG > +void online_page(struct page *page) > +{ > + ClearPageReserved(page); > + set_page_count(page, 1); > + __free_page(page); > + totalram_pages++; > + num_physpages++; > +} You're the first one to get one of these in for an alternate architecture. We'll need to keep an eye out so that one of these doesn't pop up on each of the 64-bit arches with no highmem as we add support. But, this should be just fine for now. > +int add_memory(u64 start, u64 size) > +{ > + pg_data_t *pgdat; > + struct zone *zone; > + unsigned long start_pfn = start >> PAGE_SHIFT; > + unsigned long nr_pages = size >> PAGE_SHIFT; > + int ret; > + > + pgdat = NODE_DATA(0); > + > + zone = pgdat->node_zones + ZONE_NORMAL; > + ret = __add_pages(zone, start_pfn, nr_pages); > + > + if (ret) > + printk("%s: Problem encountered in __add_pages() as ret=%d\n", __func__, ret); For some reason, I thought we were officially supposed to use __FUNCTION__ for stuff like this. However, I am usually lazy in my debugging patches and use __func__. I'm a bad example. This also looks a bit past 80 columns. -- Dave