From: dann frazier <dannf@hp.com>
To: linux-ia64@vger.kernel.org
Subject: salinfo incorrectly returning -ENOMEM
Date: Fri, 27 Jan 2006 22:21:06 +0000 [thread overview]
Message-ID: <1138400466.19287.24.camel@krebs.dannf> (raw)
salinfo_decode will silently exit occasionally due to a failed open
of /proc/sal/XXX/data. This is because the kernel is returning -ENOMEM
after attempting to vmalloc a buffer of size
ia64_sal_get_state_info_size(data->type).
However, on my system ia64_sal_get_state_info_size is returning 0, in
which case I'd think a NULL vmalloc() result is correct.
This patch assumes, of course, that 0 is a reasonable return value from
ia64_sal_get_state_info_size().
Signed-off-by: dann frazier <dannf@hp.com>
--- linux-2.6.16-rc1/arch/ia64/kernel/salinfo.c.orig 2006-01-27 14:44:20.000000000 -0700
+++ linux-2.6.16-rc1/arch/ia64/kernel/salinfo.c 2006-01-27 14:45:39.000000000 -0700
@@ -358,6 +358,7 @@ salinfo_log_open(struct inode *inode, st
{
struct proc_dir_entry *entry = PDE(inode);
struct salinfo_data *data = entry->data;
+ u64 size;
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
@@ -370,8 +371,9 @@ salinfo_log_open(struct inode *inode, st
data->open = 1;
spin_unlock(&data_lock);
- if (data->state = STATE_NO_DATA &&
- !(data->log_buffer = vmalloc(ia64_sal_get_state_info_size(data->type)))) {
+ size = ia64_sal_get_state_info_size(data->type);
+ if (data->state = STATE_NO_DATA && size &&
+ !(data->log_buffer = vmalloc(size))) {
data->open = 0;
return -ENOMEM;
}
next reply other threads:[~2006-01-27 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 22:21 dann frazier [this message]
2006-01-27 22:45 ` salinfo incorrectly returning -ENOMEM Prarit Bhargava
2006-01-27 23:24 ` dann frazier
2006-01-28 0:07 ` Keith Owens
2006-02-08 17:52 ` dann frazier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138400466.19287.24.camel@krebs.dannf \
--to=dannf@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox