From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Date: Fri, 10 Feb 2006 16:32:08 +0000 Subject: Re: [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes Message-Id: <1139589128.9209.80.camel@localhost.localdomain> List-Id: References: <20060210223841.C532.Y-GOTO@jp.fujitsu.com> In-Reply-To: <20060210223841.C532.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yasunori Goto Cc: "Luck, Tony" , Andi Kleen , "Tolentino, Matthew E" , linux-ia64@vger.kernel.org, Linux Kernel ML , x86-64 Discuss , Linux Hotplug Memory Support On Fri, 2006-02-10 at 23:20 +0900, Yasunori Goto wrote: > > static __meminit > void zone_wait_table_init(struct zone *zone, unsigned long > zone_size_pages) > { > - int i; > + int i, hotadd = (system_state = SYSTEM_RUNNING); > struct pglist_data *pgdat = zone->zone_pgdat; > + unsigned long allocsize; > > /* > * The per-page waitqueue mechanism uses hashed waitqueues > * per zone. > */ > + if (hotadd && (zone_size_pages = PAGES_PER_SECTION)) > + zone_size_pages = PAGES_PER_SECTION << 2; I don't think I understand this calculation. You online only 4 sections worth of pages? -- Dave