From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
Andi Kleen <ak@suse.de>,
"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-ia64@vger.kernel.org,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
x86-64 Discuss <discuss@x86-64.org>
Subject: Re: [PATCH: 005/012] Memory hotplug for new nodes v.2.(pgdat alloc
Date: Fri, 17 Feb 2006 15:51:37 +0000 [thread overview]
Message-ID: <1140191497.21383.77.camel@localhost.localdomain> (raw)
In-Reply-To: <20060217211729.4072.Y-GOTO@jp.fujitsu.com>
On Fri, 2006-02-17 at 22:29 +0900, Yasunori Goto wrote:
> + zone_type = start_pfn < MAX_DMA32_PFN ?
> + ZONE_DMA32 : ZONE_NORMAL;
Please change this to something which we can more easily parse, such as
this:
if (start_pfn < MAX_DMA32_PFN)
zone_type = ZONE_DMA32;
else
zone_type = ZONE_NORMAL;
I think it is worth the extra two lines.
-- Dave
prev parent reply other threads:[~2006-02-17 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 13:29 [PATCH: 005/012] Memory hotplug for new nodes v.2.(pgdat alloc caller for x86-64) Yasunori Goto
2006-02-17 15:51 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140191497.21383.77.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox