Re: [PATCH] kexec on ia64

Khalid Aziz
2006-04-05T16:11:27Z

On Mon, 2006-04-03 at 21:20 -0700, Andrew Morton wrote:
> Khalid Aziz <khalid_aziz@hp.com> wrote:
> >
> > Add kexec support on ia64.
> >
>
> Neat. How well does it work?

Works well on my test machines - HP rx2600 and HP cx2600. Hopefully
others can test it on other machines.

> > +/*
> > + * Terminate any outstanding interrupts
> > + */
> > +void terminate_irqs(void)
> > +{
> > + struct irqaction * action;
> > + irq_desc_t *idesc;
> > + int i;
> > +
> > + for (i=0; i<NR_IRQS; i++) {
>
> for (i = 0; i < NR_IRQS; i++) {
>
> > + idesc = irq_descp(i);
> > + action = idesc->action;
> > + if (!action)
> > + continue;
> > + if (idesc->handler->end)
> > + idesc->handler->end(i);
> > + }
> > +}
>
> Could we have a bit more description of what this function does, and why we
> need it?
>
> Should other kexec-using architectures be using this? If not, why does
> ia64 need it?
>
> Thanks.

This funtion terminates any outstanding interrupts. I found it to be
necessary for devices that use level interrupt. If a device, using level
interrupt, asserted its interrupt as kernel goes into panic, nobody
acknowledges its interrupt. As a result, this interrupt stays asserted
as the new kernel comes up. All drivers in their initialization routine
should clear any pending interrupts, but most do not. As a result, when
driver attempts to use the interrupt, it is unable to since the
interrupt was already asserted and any new interrupts from the device
simply cause interrupt line to continue to be asserted. terminate_irqs()
tries to acknowledge any pending interrupts so the interrupts will be
usable when the new kernel comes up. This is not specific to ia64 and I
would think this problem would show up on other architectures as well. I
happened to find it on ia64 because HP rx2600 uses level interrupts for
SCSI controller.

--
Khalid

==================================
Khalid Aziz Open Source and Linux Organization
(970)898-9214 Hewlett-Packard
khalid.aziz@hp.com Fort Collins, CO

"The Linux kernel is subject to relentless development"
- Alessandro Rubini