public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: hawkes@sgi.com
Cc: Tony Luck <tony.luck@gmail.com>, Andrew Morton <akpm@osdl.org>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jack Steiner <steiner@sgi.com>, Dan Higgins <djh@sgi.com>,
	Jeremy Higdon <jeremy@sgi.com>
Subject: Re: [PATCH] ia64: change usermode HZ to 250
Date: Wed, 28 Jun 2006 08:39:54 +0000	[thread overview]
Message-ID: <1151483994.3153.5.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060627220139.3168.69409.sendpatchset@tomahawk.engr.sgi.com>

On Tue, 2006-06-27 at 15:01 -0700, hawkes@sgi.com wrote:
> include/asm-ia64/param.h defines HZ to be 1024 for usermode use, i.e.,
> when the file gets installed as /usr/include/asm/param.h.
> As the comment says:
>     Technically, this is wrong, but some old apps still refer to it.  
>     The proper way to get the HZ value is via sysconf(_SC_CLK_TCK).
> At the very least, this technically wrong #define ought to reflect the
> current default value (250) used by all arch/ia64 platforms.  No one uses
> 1024 anymore.  This makes those "old apps" (e.g., usr/bin/iostat) behave
> properly for with a default kernel.  (And at some point, the define ought
> to be removed altogether, which would expose all the applications that
> erroneously expect HZ to be a compile-time constant.)
> 
> Signed-off-by: John Hawkes <hawkes@sgi.com>
> 
> Index: linux/include/asm-ia64/param.h
> =================================> --- linux.orig/include/asm-ia64/param.h	2006-06-17 18:49:35.000000000 -0700
> +++ linux/include/asm-ia64/param.h	2006-06-27 14:46:53.119407077 -0700
> @@ -36,7 +36,7 @@
>      * Technically, this is wrong, but some old apps still refer to it.  The proper way to
>      * get the HZ value is via sysconf(_SC_CLK_TCK).
>      */
> -# define HZ 1024
> +# define HZ 250
>  #endif

ok why not define the userspace HZ to 

#define HZ sysconf(_SC_CLK_TCK)

?



  parent reply	other threads:[~2006-06-28  8:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27 22:01 [PATCH] ia64: change usermode HZ to 250 hawkes
2006-06-27 22:26 ` Luck, Tony
2006-06-27 23:09   ` Lee Revell
2006-06-28  8:43   ` Arjan van de Ven
2006-06-28 10:47     ` Alan Cox
2006-06-28 10:34       ` Arjan van de Ven
2006-06-28 14:46         ` Christoph Lameter
2006-06-28  8:39 ` Arjan van de Ven [this message]
2006-06-28 15:43   ` John Hawkes
2006-06-28 16:21     ` Alan Cox
2006-06-28 16:11       ` John Daiker
2006-06-28 16:50         ` Alan Cox
2006-06-28 17:36 ` Luck, Tony
2006-06-29  9:37   ` Jes Sorensen
2006-06-29 10:46     ` Alan Cox
2006-06-29 10:48       ` Jes Sorensen
2006-06-29 10:55         ` Arjan van de Ven
2006-06-29 12:56           ` Jes Sorensen
2006-07-08  0:14           ` Jeremy Higdon
2006-07-08  2:51             ` Tony Luck
2006-07-08  6:42             ` Arjan van de Ven
2006-07-08 13:07               ` David Mosberger-Tang
2006-07-10 20:22                 ` Jeremy Higdon
2006-07-11  3:01                   ` David Mosberger-Tang
2006-07-11  9:53                     ` Alan Cox
2006-07-11 18:37                     ` Jeremy Higdon
2006-07-12  2:02                       ` David Mosberger-Tang
2006-06-29 11:34         ` Alan Cox
2006-06-29 14:09 ` Albert Cahalan
2006-07-09 19:18 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151483994.3153.5.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=djh@sgi.com \
    --cc=hawkes@sgi.com \
    --cc=jeremy@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steiner@sgi.com \
    --cc=tony.luck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox