From: Zou Nan hai <nanhai.zou@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Kexec/Kdump: honour non-zero crashkernel offset.
Date: Thu, 21 Sep 2006 01:01:33 +0000 [thread overview]
Message-ID: <1158800493.2718.1.camel@linux-znh> (raw)
In-Reply-To: <20060920024544.733881000@tabatha.lab.ultramonkey.org>
On Wed, 2006-09-20 at 10:43, Horms wrote:
> There seems to be a value in both allowing the kernel to determine
> the base offset of the crashkernel automatically and allowing
> users's to sepcify it.
>
> The old behaviour on ia64, which is still the current behaviour on
> most architectures is for the user to always specify the address.
> Recently ia64 was changed so that it is always automatically
> determined.
>
> With this patch the kernel automatically determines the offset if
> the supplied value is 0, otherwise it uses the value provided.
>
> This should probably be backed by a documentation change.
>
> Signed-Off-By: Simon Horman <horms@verge.net.au>
> Index: linux-2.6/arch/ia64/kernel/setup.c
> =================================> --- linux-2.6.orig/arch/ia64/kernel/setup.c 2006-09-20
> 10:56:28.000000000 +0900
> +++ linux-2.6/arch/ia64/kernel/setup.c 2006-09-20 10:58:06.000000000
> +0900
> @@ -257,7 +257,7 @@
>
> #ifdef CONFIG_KEXEC
> /* crashkernel=size@offset specifies the size to reserve for a
> crash
> - * kernel.(offset is ingored for keep compatibility with other
> archs)
> + * kernel. If offset is 0, then it is determined
> automatically.
> * By reserving this memory we guarantee that linux
> * never set's it up as a DMA target.
> * Useful for holding code to do something appropriate
> @@ -268,7 +268,7 @@
> unsigned long base, size;
> if (from) {
> size = memparse(from + 12, &from);
> - if (size) {
> + if (size && !base) {
> sort_regions(rsvd_region, n);
> base = kdump_find_rsvd_region(size,
> rsvd_region, n);
>
This patch is incorrect.
I think you will get a compile warning of base is used before it is
aligned a value here...
Thanks
Zou Nan hai
> --
> Horms
> H: http://www.vergenet.net/~horms/
> W: http://www.valinux.co.jp/en/
>
next prev parent reply other threads:[~2006-09-21 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 2:43 Kexec/Kdump: honour non-zero crashkernel offset Horms
2006-09-21 1:01 ` Zou Nan hai [this message]
2006-09-21 5:33 ` Horms
2006-09-21 5:49 ` Zou, Nanhai
2006-09-21 9:45 ` Horms
2006-10-20 5:52 ` Horms
2006-12-12 9:08 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158800493.2718.1.camel@linux-znh \
--to=nanhai.zou@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox