From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Date: Wed, 27 Sep 2006 11:48:33 +0000 Subject: Re: [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel for Message-Id: <1159359135.11049.341.camel@localhost.localdomain> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: eiichiro.oiwa.nm@hitachi.com Cc: Jesse Barnes , akpm@osdl.org, tony.luck@intel.com, greg@kroah.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Ar Mer, 2006-09-27 am 20:23 +0900, ysgrifennodd eiichiro.oiwa.nm@hitachi.com: > I moved pci_fixup_video to generic location (driver/pci/quirks.c). > I tested generic fixup_video on x86, x86_64 and IA64, and confirmed > we can read Video BIOS from the sysfs rom with embedded VGA. Lots of embedded systems don't have a PCI bios in the usual sense, and cannot run the x86 code in the ROM firmware either. That doesn't appear to be a big problem when setting PCI_ROM_SHADOW but those platforms may not all be able to access the shadow rom if one exists. Can you fix the comment in drivers/pci/rom.c to reflect the changes. Otherwise looks good. Alan