From: Zou Nan hai <nanhai.zou@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [Patch] remove some rsm psr.dt in ivt.S
Date: Tue, 17 Oct 2006 23:04:58 +0000 [thread overview]
Message-ID: <1161126298.2592.67.camel@linux-znh> (raw)
In-Reply-To: <1161123027.2592.63.camel@linux-znh>
On Wed, 2006-10-18 at 08:30, Chen, Kenneth W wrote:
> Zou Nan hai wrote on Tuesday, October 17, 2006 3:10 PM
> > The rsm psr.dt in page_not_present, key_permission, iaccess_rights
> and
> > daccess_right are not necessary.
> > Since there is no data access between those points to page_fault,
> and
> > page_fault will enable psr.dt at the beginning.
> >
> > @@ -1221,10 +1219,8 @@ END(page_not_present)
> > ENTRY(key_permission)
> > DBG_FAULT(21)
> > mov r16=cr.ifa
> > - rsm psr.dt
> > mov r31=pr
> > ;;
> > - srlz.d
> > br.sptk.many page_fault
> > END(key_permission)
>
>
> You can get rid of that stop bit too. Same for two other instances.
> And your changelog mentioned daccess_right, but patch missed that
> hunk.
>
> - Ken
>
Ok, daccess_right hunk was in the patch...
--- linux-2.6.18/arch/ia64/kernel/ivt.S 2006-10-18 00:15:11.000000000 +0800
+++ linux-2.6.18-fix/arch/ia64/kernel/ivt.S 2006-10-18 01:30:14.000000000 +0800
@@ -1201,7 +1201,6 @@ END(dispatch_to_fault_handler)
ENTRY(page_not_present)
DBG_FAULT(20)
mov r16=cr.ifa
- rsm psr.dt
/*
* The Linux page fault handler doesn't expect non-present pages to be in
* the TLB. Flush the existing entry now, so we meet that expectation.
@@ -1209,9 +1208,7 @@ ENTRY(page_not_present)
mov r17=PAGE_SHIFT<<2
;;
ptc.l r16,r17
- ;;
mov r31=pr
- srlz.d
br.sptk.many page_fault
END(page_not_present)
@@ -1221,10 +1218,7 @@ END(page_not_present)
ENTRY(key_permission)
DBG_FAULT(21)
mov r16=cr.ifa
- rsm psr.dt
mov r31=pr
- ;;
- srlz.d
br.sptk.many page_fault
END(key_permission)
@@ -1234,10 +1228,7 @@ END(key_permission)
ENTRY(iaccess_rights)
DBG_FAULT(22)
mov r16=cr.ifa
- rsm psr.dt
mov r31=pr
- ;;
- srlz.d
br.sptk.many page_fault
END(iaccess_rights)
@@ -1247,10 +1238,7 @@ END(iaccess_rights)
ENTRY(daccess_rights)
DBG_FAULT(23)
mov r16=cr.ifa
- rsm psr.dt
mov r31=pr
- ;;
- srlz.d
br.sptk.many page_fault
END(daccess_rights)
next prev parent reply other threads:[~2006-10-17 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 22:10 [Patch] remove some rsm psr.dt in ivt.S Zou Nan hai
2006-10-17 23:04 ` Zou Nan hai [this message]
2006-10-18 0:30 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161126298.2592.67.camel@linux-znh \
--to=nanhai.zou@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox