From: Zou Nan hai <nanhai.zou@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [Patch] IA64 Kdump don't clear vector in kexec_disable_iosapic
Date: Wed, 25 Oct 2006 04:40:25 +0000 [thread overview]
Message-ID: <1161751225.2592.20.camel@linux-znh> (raw)
Hi Tony,
This patch is from Naoaki-san.
Mask IOSAPIC will make the following EOI write to IOSAPIC fail because
IOSAPIC will not be able to find RTE entry.
However move EOI write before IOSAPIC mask will leave a small
racy windows between them for interrupts. So mask IOSAPIC but leave the
vector field.
The patch is against your test tree.
Signed-off-by: Zou Nan hai <nanhai.zou@intel.com>
--- linux-2.6/arch/ia64/kernel/iosapic.c 2006-10-25 14:37:30.000000000 +0800
+++ b/arch/ia64/kernel/iosapic.c 2006-10-25 14:41:34.000000000 +0800
@@ -303,7 +303,7 @@ kexec_disable_iosapic(void)
rte_list) {
iosapic_write(rte->addr,
IOSAPIC_RTE_LOW(rte->rte_index),
- IOSAPIC_MASK);
+ IOSAPIC_MASK|vec);
iosapic_eoi(rte->addr, vec);
}
}
reply other threads:[~2006-10-25 4:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161751225.2592.20.camel@linux-znh \
--to=nanhai.zou@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox