Re: Fw: [PATCH] ia64: race flushing icache in do_no_page path

Mike Stroyan
2007-07-05T17:36:21Z

On Thu, Jul 05, 2007 at 10:57:00AM +0200, Zoltan Menyhart wrote:
> KAMEZAWA Hiroyuki wrote:
> >In our test, we confirmed that this can be fixed by flushing L2I just
> >before SetPageUptodate() in NFS.
>
> I can agree.
> We can be more permissive: it can be done anywhere after the new
> data is put in place and before nfs_readpage() or nfs_readpages()
> returns.
>
> I saw your patch http://marc.info/?l=linux-mm&m\x118352909826277&w=2
> that modifies e.g. mm/memory.c and not the NFS layer.
>
> Have you proposed a patch against the NFS layer?

This really doesn't look like a job for the file system layer.
That would require all sorts of file system readpage routines to
be modified to handle memory management details that are already
handled by the memory.c functions. The do_no_page code is already
dealing with the necessary icache flushing operations. It just
happens to be doing it with a bad race condition for ia64.

--
Mike Stroyan <mike@stroyan.net>