public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Doug Chapman <doug.chapman@hp.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ia64@vger.kernel.org, vtaras@openvz.org
Subject: Re: [PATCH] ia64: fix build failure on fs/quota.c
Date: Thu, 26 Jul 2007 17:48:56 +0000	[thread overview]
Message-ID: <1185472136.20910.15.camel@dchapman.boston.redhat.com> (raw)
In-Reply-To: <1184865329.3825.25.camel@dchapman.boston.redhat.com>

On Thu, 2007-07-19 at 13:15 -0400, Doug Chapman wrote:
> Fix ia64 build failure on fs/qutoa.c.  A recent patch used the
> type compat_u64 which on ia64 is only available if CONFIG_COMPAT
> is defined.
> 
> 
> From: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Doug Chapman <doug.chapman@hp.com>
> 
> --
> 
> --- a/fs/quota.c
> +++ b/fs/quota.c
> @@ -387,7 +387,7 @@ asmlinkage long sys_quotactl(unsigned int cmd, const char __user *special, qid_t
>         return ret;
>  }
>  
> -#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
> +#if defined(CONFIG_X86_64) || (defined(CONFIG_IA64) && defined(CONFIG_COMPAT))
>  /*
>   * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64)
>   * and is necessary due to alignment problems.
> 
> 

I see that this patch has not been pulled in yet.  I am wondering if I
confused things by sending it to both linux-kernel and linux-ia64 lists
and each expected the other to pull it in?  Sorry if that breaks the
process, I am somewhat new to submitting patches.

Can we see about getting this in?  It will break the build used by
fedora/RHEL for certain and I expect other distro's as well.

thanks,

- Doug



  reply	other threads:[~2007-07-26 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19 17:15 [PATCH] ia64: fix build failure on fs/quota.c Doug Chapman
2007-07-26 17:48 ` Doug Chapman [this message]
2007-07-26 21:24 ` Luck, Tony
2007-07-26 21:58   ` Doug Chapman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1185472136.20910.15.camel@dchapman.boston.redhat.com \
    --to=doug.chapman@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vtaras@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox