From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Thu, 23 Aug 2007 16:27:42 +0000 Subject: Re: wmb vs mmiowb Message-Id: <1187886462.5972.17.camel@localhost.localdomain> List-Id: References: <20070822045714.GD26374@wotan.suse.de> <200708221202.12403.jesse.barnes@intel.com> <20070823022043.GB18788@wotan.suse.de> <20070823042038.GI18788@wotan.suse.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Torvalds Cc: Nick Piggin , linux-ia64@vger.kernel.org, Jesse Barnes , linuxppc-dev@ozlabs.org On Thu, 2007-08-23 at 09:16 -0700, Linus Torvalds wrote: > > On Thu, 23 Aug 2007, Nick Piggin wrote: > > > > Also, FWIW, there are some advantages of deferring the mmiowb thingy > > until the point of unlock. > > And that is exactly what ppc64 does. > > But you're missing a big point: for 99.9% of all hardware, mmiowb() is a > total no-op. So when you talk about "advantages", you're not talking about > any *real* advantage, are you? I wonder whether it might be worth removing mmiowb and having all archs that matter do like ppc64 though... It's just yet another confusing barrier that most driver writers get wrong.. Cheers, Ben.