From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zou Nan hai <nanhai.zou@intel.com>
Date: Fri, 31 Aug 2007 01:48:07 +0000
Subject: RE: [PATCH 1/1] Allow global purge traslation cache (ptc.g) to
Message-Id: <1188524887.2583.17.camel@linux-znh>
List-Id: <linux-ia64.vger.kernel.org>
References: <200708301338.34246.protasnb@gmail.com>
In-Reply-To: <200708301338.34246.protasnb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-ia64@vger.kernel.org

On Fri, 2007-08-31 at 09:45, Luck, Tony wrote:
> > Please consider the scenario when many cpus are calling
> > ia64_global_tlb_purge at the same time without any lock.
> > Using global variables to indicate tlb flush start and end is not safe
> > here.	
> 
> Isn't everything protected by the
> 
> 	spin_lock(&ptcg_lock);
> 	 ...
> 	spin_unlock(&ptcg_lock);
> 
> in ia64_global_tlb_purge()?  Though the comment that this lock
> is required for HW serialization would need to be updated to
> note that the s/w implementation also requires this serialization.
> 
> -Tony

Ah Yes, I missed this line when reading the patch...

So my comments would be
1. avoid declare global variables and functions in .c file. 
2. use more precise name for global variable.to e.g 
   ia64_global_tlb_flush_start is better than flush_start.
3. do not use asm in .c file, use intrins instead.

Thanks
Zou Nan hai