From: Petr Tesarik <ptesarik@suse.cz>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 1/3] ia64: fix ptrace inside a namespace
Date: Thu, 06 Mar 2008 08:17:09 +0000 [thread overview]
Message-ID: <1204791429.16716.1.camel@elijah.suse.cz> (raw)
In-Reply-To: <200803042314.m24NEwT5002321@imap1.linux-foundation.org>
On Tue, 2008-03-04 at 15:14 -0800, akpm@linux-foundation.org wrote:
> From: Pavel Emelyanov <xemul@openvz.org>
>
> The ia64 has its own sys_ptrace implementation and it was overlooked when the
> pid namespaces patches were sent.
>
> Use find_task_by_vpid() in it.
And there we are. If we don't push the ptrace() changes into mainline
soon, mainline will drift away from us. :(
Cheers,
Petr Tesarik
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: "Luck, Tony" <tony.luck@intel.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> arch/ia64/kernel/ptrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace arch/ia64/kernel/ptrace.c
> --- a/arch/ia64/kernel/ptrace.c~ia64-fix-ptrace-inside-a-namespace
> +++ a/arch/ia64/kernel/ptrace.c
> @@ -1561,7 +1561,7 @@ sys_ptrace (long request, pid_t pid, uns
> ret = -ESRCH;
> read_lock(&tasklist_lock);
> {
> - child = find_task_by_pid(pid);
> + child = find_task_by_vpid(pid);
> if (child) {
> if (peek_or_poke)
> child = find_thread_for_addr(child, addr);
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-03-06 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 23:14 [patch 1/3] ia64: fix ptrace inside a namespace akpm
2008-03-06 8:17 ` Petr Tesarik [this message]
2008-03-06 17:03 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204791429.16716.1.camel@elijah.suse.cz \
--to=ptesarik@suse.cz \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox