public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: RE: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish
Date: Wed, 19 Mar 2008 23:23:59 +0000	[thread overview]
Message-ID: <1205969039.6437.44.camel@lappy> (raw)
In-Reply-To: <DDF46CB71CB9D647A983FECACF09A886A8A6B5@orsmsx424.amr.corp.intel.com>

On Tue, 2008-03-18 at 17:14 -0700, Yu, Fenghua wrote:
> >this paramter mean use all physical memory and about 1GB swap space.
> >Could you expand swap space?
> 
> We can reproduce the soft lockup issue now and root cause the issue as
> well.
> 
> Since the ptc.g patch uses semaphore ptcg_sem to serialize multiple
> ptc.g instructions in ia64_global_tlb_purge(). This requires the code
> path should be safe to sleep in down(). But the code path can not sleep
> during swap because it holds some spin locks (e.g. anon_vma_lock). Going
> to sleep finally causes soft lockup.
> 
> Actually we though of this issue before releasing the ptcg patch and
> wrote some non-sleeping versions of ptcg patches. But since we couldn't
> see the sleeping issue during our testing, we didn't release a
> non-sleeping ptcg patch. If replacing the ptcg patch in -mm1 tree with
> one of our non-sleeping ptcg patches, the issue goes away.
> 
> Tony and I are working on releasing a final ptcg patch to solve the
> issue.

Which makes me wonder, why did you ever use a semaphore here? Looking at
the code its a straight forward mutex. And when you would have used a
mutex lockdep would have warned about this.

There is hardly ever a good reason to use semaphores in new code, we're
trying very hard to get rid of them.

Hmm, then again, does ia64 have lockdep?


  reply	other threads:[~2008-03-19 23:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 11:18 [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish >12 hour KOSAKI Motohiro
2008-03-17 11:51 ` KOSAKI Motohiro
2008-03-17 16:09   ` Luck, Tony
2008-03-17 23:43     ` KOSAKI Motohiro
2008-03-17 17:38 ` Luck, Tony
2008-03-17 23:44   ` KOSAKI Motohiro
2008-03-18  0:36     ` Yu, Fenghua
2008-03-18  0:47       ` KOSAKI Motohiro
2008-03-19  0:14         ` Yu, Fenghua
2008-03-19 23:23           ` Peter Zijlstra [this message]
2008-03-19 23:50             ` [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish>12 hour Yu, Fenghua
2008-03-20  3:39             ` [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish >12 hour Luming Yu
2008-03-20  4:51               ` KOSAKI Motohiro
2008-03-20 16:04             ` [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish>12 hour Luck, Tony
2008-03-20 16:16               ` [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish>12 Peter Zijlstra
2008-03-20 17:23                 ` [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish>12hour Luck, Tony
2008-04-04 23:52           ` [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't finish >12 hour Luck, Tony
2008-04-05  5:03             ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205969039.6437.44.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=fenghua.yu@intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox