Re: IPF Montvale machine panic when running a network-relevent

David Miller
2008-06-18T03:37:03Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1124 bytes --]

From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Date: Wed, 18 Jun 2008 11:27:43 +0800

> This issue is caused by tcp defer accept. Mostly, process context calls lock_sock
> to apply a sleeping lock. BH (SoftIRQ) context calls bh_lock_sock(_nested) to just apply
> for the sk->sk_lock.slock without sleeping, then do appropriate processing based on
> if sk->sk_lock.owned=0. That works well if both process context and BH context operate
> the same sk at the same time. But with ï»¿tcp defer accept, it doesn't, because
> process context(for example, in inet_csk_accept) locks the listen sk, while BH
> context (in tcp_v4_rcv, for example) locks the child sk and calls
> ï»¿tcp_defer_accept_checkï»¿ => inet_csk_reqsk_queue_add => reqsk_queue_add, so there is a race
> to access the listen sock.
>
> Below patch against 2.6.26-rc6 fixes the issue.
>
> ï»¿ï»¿Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com>

We reverted the guilty defer accept changes, please test Linus's
current tree.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þ&ºãø§¶\x17›¡Ü¨}©ž²Æ zÚ&j:+v‰¨þø\x1e¯ù\x1e®w¥þŠà2ŠÞ™¨è­Ú&¢)ß¡«a¶Úÿÿûàz¿äz¹Þ—ú+ƒùšŽŠÝ¢jÿŠwèþ^[f