Re: [PATCH 9/22] ia64: Introducing asm/syscalls.h

Jaswinder Singh
2008-07-21T05:31:44Z

Hello Matthew,

On Sun, 2008-07-20 at 18:19 -0600, Matthew Wilcox wrote:
> On Mon, Jul 21, 2008 at 05:03:55AM +0530, Jaswinder Singh wrote:
> > Declaring arch-dependent syscalls for ia64 architecture
> > +#ifndef CONFIG_PCI
> > +asmlinkage long sys_pciconfig_read(unsigned long, unsigned long,
> > + unsigned long, unsigned long, void *);
> > +asmlinkage long sys_pciconfig_write(unsigned long, unsigned long,
> > + unsigned long, unsigned long, void *);
> > +#endif /* CONFIG_PCI */
>
> These are already declared in linux/syscalls.h
>
> And frankly, we should just make these return -ENOSYS always. Any
> software that uses them is stuffed on machines with multiple domains.
>

diff --git a/include/asm-ia64/syscalls.h b/include/asm-ia64/syscalls.h
index 71af530..8799e14 100644
--- a/include/asm-ia64/syscalls.h
+++ b/include/asm-ia64/syscalls.h
@@ -28,11 +28,5 @@ asmlinkage unsigned long sys_mmap2(unsigned long, unsigned long,
int, int, int, long);
asmlinkage unsigned long sys_mmap(unsigned long, unsigned long,
int, int, int, long);
-#ifndef CONFIG_PCI
-asmlinkage long sys_pciconfig_read(unsigned long, unsigned long,
- unsigned long, unsigned long, void *);
-asmlinkage long sys_pciconfig_write(unsigned long, unsigned long,
- unsigned long, unsigned long, void *);
-#endif /* CONFIG_PCI */

#endif /* _ASM_IA64_SYSCALLS_H */

Thank you,

Jaswinder Singh.