From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Fri, 06 Jan 2012 13:03:01 +0000 Subject: Re: [RFC PATCH 0/9] Remove useless on_each_cpu return value Message-Id: <1325854981.2442.25.camel@twins> List-Id: References: <1325600353-10895-1-git-send-email-gilad@benyossef.com> In-Reply-To: <1325600353-10895-1-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gilad Ben-Yossef Cc: linux-kernel@vger.kernel.org, Michal Nazarewicz , David Airlie , dri-devel@lists.freedesktop.org, Benjamin Herrenschmidt , Paul Mackerras , Grant Likely , Rob Herring , linuxppc-dev@lists.ozlabs.org, devicetree-discuss@lists.ozlabs.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, Will Deacon , Arnaldo Carvalho de Melo , Russell King , linux-arm-kernel@lists.infradead.org On Tue, 2012-01-03 at 16:19 +0200, Gilad Ben-Yossef wrote: > on_each_cpu() returns as its own return value the return value of > smp_call_function(). smp_call_function() in turn returns a hard > coded value of zero. > > Some callers to on_each_cpu() waste cycles and bloat code space > by checking the return value to on_each_cpu(), probably for > historical reasons. hysterical raisins,, yumm! :-) > This patch set refactors callers to not test on_each_cpu() > (fixed) return value and then refactors on_each_cpu to > return void to avoid confusing future users. > Seems sane enough, fwiw: Acked-by: Peter Zijlstra