From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] ia64: fix halt build fallout from deeper C state support.
Date: Tue, 03 Apr 2012 16:18:03 +0000 [thread overview]
Message-ID: <1333469883-20509-1-git-send-email-paul.gortmaker@windriver.com> (raw)
Commit 1a022e3f1be11730bd8747b1af96a0274bf6356e
"idle, x86: Allow off-lined CPU to enter deeper C states"
causes ia64 defconfig to fail with:
drivers/acpi/processor_idle.c:789:4: error: implicit declaration of function 'halt' [-Werror=implicit-function-declaration]
For i386 we have:
halt
--> native_halt
--> asm hlt
arch_safe_halt
--> native_safe_halt
--> asm sti; hlt
On ia64, we just have:
arch_safe_halt
--> ia64_pal_halt_light
but there is no equivalent to just plain "halt"
The comments for ia64_pal_halt_light in arch/ia64/include/asm/pal.h indicate:
Cause the processor to enter LIGHT HALT state, where prefetching
and execution are suspended, but cache and TLB coherency is
maintained.
Based on that, it seems reasonable to make halt point to that.
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Boris Ostrovsky <boris.ostrovsky@amd.com>
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Tony - I dont know enough about ia64 to be sure this makes sense,
so feel free to junk this patch and treat the mail as just a build
failure regression report if there is a better fix.]
diff --git a/arch/ia64/include/asm/irqflags.h b/arch/ia64/include/asm/irqflags.h
index 2b68d85..30590c9 100644
--- a/arch/ia64/include/asm/irqflags.h
+++ b/arch/ia64/include/asm/irqflags.h
@@ -92,5 +92,9 @@ static inline void arch_safe_halt(void)
ia64_pal_halt_light(); /* PAL_HALT_LIGHT */
}
+static inline void halt(void)
+{
+ arch_safe_halt();
+}
#endif /* _ASM_IA64_IRQFLAGS_H */
--
1.7.9.1
next reply other threads:[~2012-04-03 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 16:18 Paul Gortmaker [this message]
2012-04-03 18:11 ` [PATCH] ia64: fix halt build fallout from deeper C state support Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333469883-20509-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).