Re: [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents

Konrad Rzeszutek Wilk
2014-02-03T14:52:05Z

On Fri, Jan 31, 2014 at 10:28:22AM +0100, Sander Eikelenboom wrote:
> Hi Bjorn / Tony,
>
> I fixed up ia64 as well and brought it inline again with the x86 code,
> but i don't have a ia64 machine, so that part is untested.
> Perhaps Tony is able to review/test it ?
>
> Sander
>
>
>
> Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary
> prevents it from reading it's own rom. It will get the content of the shadowrom
> at C000 instead, which is of the primary VGA card and the driver of the
> secondary card will bail out.
>
> Fix this by checking if the arch code or vga-arbitration has already
> determined the vga_default_device, if so only apply the fix to this
> primary video device and let the comment reflect this.
>
> v2:
> - Fix pci_fixup_video both in x86 and ia64
>
>
> Sander Eikelenboom (1):
> Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the
> primary prevents it from reading it's own rom. It will get the
> content of the shadowrom at C000 instead, which is of the
> primary VGA card and the driver of the secondary card will bail
> out.

Your editor mutilated your subject line. It ought to have been just
one line.

Anyhow, you can also add 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com'
on the patch for the x86 part.

The ia64 "looks" OK to me, but my ia64 box won't boot v3.11 or later
so I can't give it a 'Tested-by' yet.

>
> arch/ia64/pci/fixup.c | 24 +++++++++++++-----------
> arch/x86/pci/fixup.c | 18 ++++++++++--------
> 2 files changed, 23 insertions(+), 19 deletions(-)
>
> --
> 1.7.10.4
>