From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Mon, 28 Apr 2014 00:43:21 +0000 Subject: Re: [PATCH 08/13] PCI, rpaphp: Use new pci_is_bridge() to simplify code Message-Id: <1398645801.8437.84.camel@pasglop> List-Id: References: <1398417515-8740-1-git-send-email-wangyijing@huawei.com> <1398417515-8740-9-git-send-email-wangyijing@huawei.com> In-Reply-To: <1398417515-8740-9-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yijing Wang Cc: Bjorn Helgaas , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Thomas Gleixner , x86@kernel.org On Fri, 2014-04-25 at 17:18 +0800, Yijing Wang wrote: > Now we can use new pci_is_bridge() helper function > to simplify code. > > Signed-off-by: Yijing Wang Acked-by: Benjamin Herrenschmidt > --- > drivers/pci/hotplug/rpadlpar_core.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index 4fcdeed..7660232 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -157,8 +157,7 @@ static void dlpar_pci_add_bus(struct device_node *dn) > } > > /* Scan below the new bridge */ > - if (dev->hdr_type = PCI_HEADER_TYPE_BRIDGE || > - dev->hdr_type = PCI_HEADER_TYPE_CARDBUS) > + if (pci_is_bridge(dev)) > of_scan_pci_bridge(dev); > > /* Map IO space for child bus, which may or may not succeed */